Skip to content

Add PTB HLT and LLT information to CAF files for real SBND data#614

Open
hbjamin wants to merge 2 commits intodevelopfrom
feature/hbjamin_PTBTriggerInfoToCAFs_v10_06_00_02
Open

Add PTB HLT and LLT information to CAF files for real SBND data#614
hbjamin wants to merge 2 commits intodevelopfrom
feature/hbjamin_PTBTriggerInfoToCAFs_v10_06_00_02

Conversation

@hbjamin
Copy link

@hbjamin hbjamin commented Dec 4, 2025 •
edited
Loading

Description

This PR adds PTB information to CAF files for real SBND data, which is required for trigger efficiency studies using zero bias data. The implementation extracts all HLT (High Level Trigger) and LLT (Low Level Trigger) information from PTB fragments, decodes trigger words into individual bits, and stores them separately in the CAF structure. This PR requires merging SBNSoftware/sbnanaobj#180

  • Have you added a label? (bug/enhancement/physics etc.)
  • Have you assigned at least 1 reviewer?
  • Is this PR related to an open issue / project?
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer as additional reviewer.
  • Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)? If so, please link it in the description.
  • Are you submitting this PR on behalf of someone else who made the code changes? If so, please mention them in the description.

@hbjamin hbjamin requested review from kjplows and lynnt20 December 4, 2025 18:16
@hbjamin hbjamin added the enhancement New feature or request label Dec 4, 2025
@hbjamin hbjamin requested review from fjnicolas and terezakroupa and removed request for lynnt20 December 4, 2025 18:46
@kjplows kjplows moved this to Open pull requests in SBN software development Dec 14, 2025
fjnicolas
fjnicolas reviewed Jan 5, 2026
View reviewed changes
Copy link
Contributor

@fjnicolas fjnicolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @hbjamin! See comment in SBNSoftware/sbnanaobj#180 about uint64_t for the decoded HLT/LLT IDs

terezakroupa
terezakroupa approved these changes Jan 6, 2026
View reviewed changes
Copy link

@terezakroupa terezakroupa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ben, looks great!

PetrilloAtWork
PetrilloAtWork requested changes Jan 9, 2026
View reviewed changes
Copy link
Member

@PetrilloAtWork PetrilloAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have dropped a few technical suggestions.
But more importantly I would like the author to deeply think about the real need for a catch(...) in the code.

@PetrilloAtWork PetrilloAtWork mentioned this pull request Jan 9, 2026
Open
4 tasks
@hbjamin
Copy link
Author

hbjamin commented Jan 9, 2026

Thank you for the good suggestions. There was no reason for me to use a catch statement. It was leftover from my initial debugging of extractAllPTBInfo. I've also included several changes that result from making the timestamps a uint64_t that stores nanoseconds since UTC epoch instead of a double that stores seconds since UTC epoch to avoid rounding jumps occurring at 256 and 512 ns

@kjplows kjplows moved this from Open pull requests to Partially reviewed in SBN software development Jan 15, 2026
@kjplows
Copy link
Contributor

kjplows commented Jan 15, 2026

Thanks @hbjamin ! @PetrilloAtWork , do the changes look good to you? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PetrilloAtWork PetrilloAtWork PetrilloAtWork requested changes

@terezakroupa terezakroupa terezakroupa approved these changes

@fjnicolas fjnicolas fjnicolas approved these changes

@kjplows kjplows Awaiting requested review from kjplows

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

SBN software development
Status: Partially reviewed

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hbjamin @kjplows @terezakroupa @PetrilloAtWork @fjnicolas @maxdubnowski